Complete Metrics System Standardization and Real-Time Fixes#16
Merged
Complete Metrics System Standardization and Real-Time Fixes#16
Conversation
…cumulative - Replace cumulative metrics collection with real-time per-batch metrics - Add currentBatch tracking to monitor which batch size is actively being tested - Background metrics now save current transaction/row rates for the active batch - Remove confusing cumulative metrics across different batch sizes - Metrics now show what's happening 'right now' for better real-time analysis - Add batch size to all metric tags for proper categorization - Reset current batch tracking when test completes This fixes the logical flaw where cumulative metrics across different batch sizes made no sense for real-time monitoring and analysis.
- Clean up tags by removing null batch_count entries - batch_count doesn't make sense for real-time current batch metrics - Simplifies tag structure and removes confusing null values
…mulative - Add previous metrics tracking (prevTransactions, prevRows, prevSaveTime) - Calculate delta values between saves for true interval metrics - Change metric_type to 'interval_*' to reflect actual behavior - Add interval_transactions, interval_rows, interval_seconds to tags - Initialize and reset previous metrics at batch start/end - Skip first iteration until we have baseline previous values Now background metrics show actual work done in each 1-second interval instead of cumulative totals since test start. This provides proper real-time monitoring with meaningful rate calculations.
Background Metrics Improvements: - Fix TPC-C plugin to use delta calculation instead of cumulative metrics - Add previous metrics tracking (prevTotalTxns, prevSaveTime) to TPC-C - Update TPC-C to save 'interval_*' metrics with proper time window calculations - Initialize/reset previous metrics at connection level start in TPC-C Final Results Cleanup: - Remove unnecessary null fields (batch_size, total_rows, batch_count) from TPC-C final results - Remove batch_count field from bulk-load final results - Simplify tag structures to only include relevant fields per plugin type Consistency Improvements: - Standardize metric_type naming: 'interval_*' for background, specific names for final - Ensure all background metrics calculate rates based on actual work done in time interval - Clean tag structures across both plugins for better analysis and filtering Both plugins now provide true real-time monitoring with meaningful interval-based metrics instead of misleading cumulative calculations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR completes the comprehensive review and standardization of the metrics system across both plugins, fixing the fundamental design flaws in background metrics collection.
Key Changes
Background Metrics Redesign
Metrics Consistency
Tag Structure Cleanup
Database Schema Compatibility
Problem Solved
Before: Background metrics showed meaningless cumulative totals:
After: Real-time interval metrics:
Testing
Impact
Ready for production testing and integration --head v2-redesign-core --base main